Adds eg-brs extensions #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for: * native custom element tag names * content projection via ng-content * less verbose configuration when many components are registered.
brunob15
requested changes
Jan 30, 2021
| @@ -97,7 +106,7 @@ export class NgxElementComponent implements OnInit, OnDestroy { | |||
| for (let attr, i = 0; i < attrs.length; i++) { | |||
| attr = attrs[i]; | |||
|
|
|||
| if (attr.nodeName.match('^data-')) { | |||
| if ((!this.registry.useCustomElementNames && attr.nodeName.match('^data-')) || this.registry.useCustomElementNames) { | |||
There was a problem hiding this comment.
The property useCustomElementNames in the registry also affects the attributes that can be passed to the element?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for:
<app-talk title="My talk"></app-talk>)<app-talk><span>This is projected</span></app-talk>)