Turn hard coded values into parameters. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Values affecting mode 1 and 2 of the standard PLL have been conveted to tunable parameters. The min and max values are far apart and may need to be tightened up. The scheduling delay in main_sim_client.c and the cut off for ancient packets in ntp_filter.c has veen turned into parameters too.
runema
changed the title
rwarren
reviewed
Jul 19, 2017
param_tbl.h
Outdated
| PARAM_NTP_FILTER(ntp_filter_ancient, | ||
| 256, 4096, 2048, | ||
| "Packet delays exceeding the average by this amount are too old." | ||
| " Theese events are logged." |
rwarren
reviewed
Jul 19, 2017
param_tbl.h
Outdated
| 256, 4096, 2048, | ||
| "Packet delays exceeding the average by this amount are too old." | ||
| " Theese events are logged." | ||
| " Setting this too high and the clock man become eratic." |
There was a problem hiding this comment.
Should probably be "may become erratic"
rwarren
reviewed
Jul 19, 2017
param_tbl.h
Outdated
| "Treshold for stepping clock at startup.\n\n" | ||
| "Reducing this will step the clock at smaller errors." | ||
| " Increasing this makes the PLL more tolerant and" | ||
| " reduce the chance that the clock is stepped." |
Fix spelling in param_tbl.h .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values affecting mode 1 and 2 of the standard PLL have been converted to
tune-able parameters. The min and max values are far apart and may need to be
tightened up. The scheduling delay in main_sim_client.c and the cut off
for ancient packets in ntp_filter.c has veen turned into parameters too.