Skip to content

Modified response code 400 to 401 #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Modified response code 400 to 401 #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f1570b
Modified response code 400 to 401
whvandervelde Jun 4, 2019
b94f72b
Added missing test
whvandervelde Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OAuth2/ClientAssertionType/HttpBasic.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function validateRequest(RequestInterface $request, ResponseInterface $re
return false;
}
} elseif ($this->storage->checkClientCredentials($clientData['client_id'], $clientData['client_secret']) === false) {
$response->setError(400, 'invalid_client', 'The client credentials are invalid');
$response->setError(401, 'invalid_client', 'The client credentials are invalid');

return false;
}
Expand Down
4 changes: 2 additions & 2 deletions test/OAuth2/Controller/TokenControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public function testInvalidClientId()
));
$server->handleTokenRequest($request, $response = new Response());

$this->assertEquals($response->getStatusCode(), 400);
$this->assertEquals($response->getStatusCode(), 401);
$this->assertEquals($response->getParameter('error'), 'invalid_client');
$this->assertEquals($response->getParameter('error_description'), 'The client credentials are invalid');
}
Expand All @@ -113,7 +113,7 @@ public function testInvalidClientSecret()
));
$server->handleTokenRequest($request, $response = new Response());

$this->assertEquals($response->getStatusCode(), 400);
$this->assertEquals($response->getStatusCode(), 401);
$this->assertEquals($response->getParameter('error'), 'invalid_client');
$this->assertEquals($response->getParameter('error_description'), 'The client credentials are invalid');
}
Expand Down
2 changes: 1 addition & 1 deletion test/OAuth2/GrantType/ClientCredentialsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function testInvalidCredentials()
));
$server->handleTokenRequest($request, $response = new Response());

$this->assertEquals($response->getStatusCode(), 400);
$this->assertEquals($response->getStatusCode(), 401);
$this->assertEquals($response->getParameter('error'), 'invalid_client');
$this->assertEquals($response->getParameter('error_description'), 'The client credentials are invalid');
}
Expand Down