Fix #66 Add tag results at the end #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you for this, @acirep! I am currently on vacation without a laptop, so I will review this once I am back in early August. I hope that's okay :) |
Collaborator
Author
Oh no worries at all, enjoy your vacation - I hope you are having fun! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @bsiegert ,
this took me quite some time to find a right approach and it is working but to be honest I don't like it! When the list of results is long, it pushes what user types to the end of the list and it is not visible at all until you scroll down. I like it much more how it was on the top so I suggest we don't do this and just discard this PR and close related issue.
Let me know what do you think!