4377: subtree benchmarks

[liam]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

---

Summary: This PR adds comprehensive subtree benchmarking tests across three files. The code is well-structured with good separation of concerns and thorough performance analysis. Found one issue with the init() function approach.

Issues Found:

1. Unsafe init() function with empty testing.T (subtree_size_benchmark_test.go:207-218) - Creates transaction hashes at package initialization using &testing.T{}. This bypasses proper test setup and can cause silent failures or panics at import time. Consider lazy initialization on first use instead.

Positive Observations:

• Excellent test organization with clear separation between timing tests, benchmarks, and overhead analysis
• Good use of table-driven tests for comparing different subtree sizes
• Comprehensive documentation explaining the purpose of each benchmark
• Proper use of b.Helper() and t.Helper() throughout
• Shared test helpers in blockvalidation/testhelpers reduce code duplication
• Tests properly skip in short mode with testing.Short()

The subtree benchmarking infrastructure looks solid and will provide valuable performance insights for optimizing subtree sizes.

[github-actions]

Issue 1: Incorrect transaction count (line 58)

The function CreateTestTransactionChainWithCount returns count-1 transactions (due to the loop using count-2 at line 41 in transactions.go). When calling with tc.txCount (5000), you get 4999 transactions, not 5000. This affects tx/sec calculations and subtree count assertions.

Issue 2: Unsafe testing.T usage in init() (line 212)

Using an uninitialized testing.T struct in package init() is unsafe. If CreateTestTransactionChainWithCount calls any t methods (like t.Fatalf), it will panic and prevent the package from loading.

Consider using hardcoded hashes, lazy initialization with sync.Once, or generating on first benchmark use.

[sonarqubecloud]

Quality Gate passed

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud