Skip to content

Conversation

@torrejonv
Copy link
Collaborator

  • Correct 'go run' command syntax by adding missing '.' argument
  • Update block invalidation flow to accurately reflect database operations
  • Remove unsupported '+ 1' claim from UTXO freezing description

All changes verified against actual implementation in services/alert/node.go, services/blockchain/Server.go, and stores/blockchain/sql/InvalidateBlock.go

- Correct 'go run' command syntax by adding missing '.' argument
- Update block invalidation flow to accurately reflect database operations
- Remove unsupported '+ 1' claim from UTXO freezing description

All changes verified against actual implementation in services/alert/node.go,
services/blockchain/Server.go, and stores/blockchain/sql/InvalidateBlock.go
@torrejonv torrejonv enabled auto-merge (squash) November 27, 2025 20:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

🤖 Claude Code Review

Status: Complete

Documentation corrections verified against implementation.


Summary: No issues found. The PR accurately corrects documentation to match the actual implementation:

  1. UTXO Freezing (line 26): Removes unsupported "+ 1" claim - correctly states UTXOs are frozen at the specified height without offset
  2. Block Invalidation (lines 176-182): Accurately reflects database operations in stores/blockchain/sql/InvalidateBlock.go:
    • Uses recursive CTE to mark blocks as invalid
    • Sets mined_set = false for invalidated blocks
    • Returns list of invalidated block hashes
    • Does NOT re-validate transactions or manipulate chain tip (previous docs incorrectly described steps 4-5)

All changes verified against implementation files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant