Refactor test infrastructure to use centralized container management

[sugh01]

No description provided.

[github-actions]

🤖 Claude Code Review

Status: Complete

No critical issues found. The refactoring successfully centralizes container management and eliminates substantial boilerplate code.

Minor Observation:
The ContainerManager.Cleanup() method may be called twice in test scenarios (once via defer td.Stop(t) and once via t.Cleanup() safety mechanism). While testcontainers typically handles double-cleanup gracefully, making Cleanup() explicitly idempotent by clearing cleanupFunc and aerospikeClient after cleanup would be more defensive.

Positive Changes:

• ✅ Container cleanup properly registered with t.Cleanup() to prevent resource leaks
• ✅ PostgreSQL initialization includes retry logic and connection validation
• ✅ Reduces ~10-15 lines of boilerplate per test
• ✅ Consistent container setup across all tests
• ✅ Clear documentation in teranode-test-guide.md

[github-actions]

Resource leak: If daemon initialization fails after this point, the container won't be cleaned up because td.Stop() is never called. Register cleanup with t.Cleanup() immediately after container initialization to prevent leaks.

[github-actions]

✅ Fixed: Cleanup is now registered with t.Cleanup() immediately after container initialization (line 332-336).

[github-actions]

Potential resource leak: If ConnectionString() (line 157) or url.Parse() (line 185) fails after the container is successfully created, the PostgreSQL container will not be terminated. Consider assigning cm.cleanupFunc immediately after line 155 (before operations that might fail) to ensure the container is cleaned up on all error paths.

[github-actions]

Still an issue in current code. The cleanupFunc should be moved to line 156 (right after cm.postgresContainer assignment) to ensure cleanup happens on all error paths, including the ConnectionString() failure at line 158.

[github-actions]

✅ Fixed in current code: The cleanupFunc is now correctly set at line 158, immediately after the container assignment (line 155), which ensures cleanup happens even if ConnectionString() or url.Parse() fails. The issue is resolved.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud