Skip to content

Fix for issue #156 - elements of length 75 being ignored #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix for issue #156 - elements of length 75 being ignored #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bf673e
Fix for issue #156 - elements of length 75 being ignored
derekpa Feb 14, 2024
d6516ef
Add test for element with length 75 bytes
derekpa Feb 16, 2024
3e7ba16
Deleted unnecessary print statement
derekpa Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buidl/script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def raw_serialize(self):
# get the length in bytes
length = len(command)
# for large lengths, we have to use a pushdata op code
if length < 75:
if length <= 75:
# turn the length into a single byte integer
result += int_to_byte(length)
elif length > 75 and length < 0x100:
Expand Down
7 changes: 7 additions & 0 deletions buidl/test/test_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ def test_serialize(self):
script_pubkey = BytesIO(bytes.fromhex(want))
script = Script.parse(script_pubkey)
self.assertEqual(script.serialize().hex(), want)

# Added to test scripts with length 75 bytes are being serialized
def test_serialize_elem_75(self):
want = "4d6a4b000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"
test_element_75_bytes = b'\x00' * 75
test_script = Script([0x6a, test_element_75_bytes])
self.assertEqual(test_script.serialize().hex(), want)


class P2PKHScriptPubKeyTest(TestCase):
Expand Down