Skip to content

Conversation

rw-bsi
Copy link
Contributor

@rw-bsi rw-bsi commented Sep 20, 2025

Prevents duplicate user accounts (eg. user@.... and User@.... are now treated as the same)

Copy link
Contributor

@civilx64 civilx64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of notes for consideration:

  1. are there any performance implications from case-insensitive searches where an index in the DB would be helpful?
  2. Can you add a unit test for this? Maybe change the credentials in one file to rOOt:root?

@rw-bsi
Copy link
Contributor Author

rw-bsi commented Sep 21, 2025

Thanks @civilx64

are there any performance implications from case-insensitive searches where an index in the DB would be helpful?

Will have a look - this username field is default Django so not sure a case-insensitive index already exists (if not, I'll add one)

Can you add a unit test for this? Maybe change the credentials in one file to rOOt:root?

We haven't changed Django Admin users behaviour, only the Entra ID <> Django mapping.
Django default is to treat root and rOOt as different users (in Django Admin, in API, etc...)
I can add a test for the former though.

@rw-bsi rw-bsi marked this pull request as draft September 21, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants