Skip to content

Conversation

@KevinGrandon
Copy link
Contributor

This is something that we're currently using in order to leverage docker containers across pipelines. Possibly there's a better way of doing this? Aliases perhaps?

@KevinGrandon KevinGrandon requested a review from a team as a code owner July 16, 2025 00:00
@toote
Copy link
Contributor

toote commented Jul 16, 2025

Interesting... but I am not sure exactly what need this fulfills. It appears to be the exact same thing as the prebuilt image for services that is already implemented using metadata as well and actually uses the exact same underlying primitives. Or is there a scenario I am missing that such information is not enough and the digest is necessary instead?

If this were really necessary, I would instead suggest adding a boolean option to the plugin so that it saves the image reference for the prebuilt image metadata it already has with the digest instead of what it does now. That way the code paths are the same with a lot less duplicated code.

@KevinGrandon
Copy link
Contributor Author

Interesting... but I am not sure exactly what need this fulfills. It appears to be the exact same thing as the prebuilt image for services that is already implemented using metadata as well and actually uses the exact same underlying primitives. Or is there a scenario I am missing that such information is not enough and the digest is necessary instead?

Apologies if I missed it, I didn't see the prebuilt image URI with digest stored in metadata. I'll evaluate again, if it is, this is not needed, but I couldn't find it.

@toote
Copy link
Contributor

toote commented Jul 24, 2025

I didn't see the prebuilt image URI with digest stored in metadata.

It is not, it is stored as the pushed tag. If you want or need the digest my original suggestion would still stand: a boolean flag to use the tag (current behavior) or the digest. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants