This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Remove permanent connection checkouts #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
remove-permanent-connection-checkouts
branch
from
843ed76 to
7214e8b
Compare
joshuay03
commented
Jun 30, 2025
| gem "activerecord", "~> 7.0.0" | ||
| gem "activerecord" |
There was a problem hiding this comment.
Ensures we run local tests on the latest Rails. CI should be responsible for catching backward incompatible changes.
joshuay03
force-pushed
the
remove-permanent-connection-checkouts
branch
5 times, most recently
from
a417e60 to
48379b8
Compare
joshuay03
force-pushed
the
remove-permanent-connection-checkouts
branch
from
48379b8 to
35a45bf
Compare
|
For posterity, I closed this in favour of the upstream implementation, which I only found after opening this: 7960910 Related discussion here re: syncing with upstream: https://buildkite-corp.slack.com/archives/C05NAGJREJU/p1751259519636459 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required to prevent the changes in https://github.com/buildkite/buildkite/pull/20828 from regressing.
Similar to activerecord-hackery/ransack#1570.