Skip to content

Conversation

@bvaughn
Copy link
Owner

@bvaughn bvaughn commented Apr 29, 2016

@MikeMcElroy
Copy link
Contributor

Big +1 on named arguments -- couldn't find a way to comment on that on the wiki.

@MikeMcElroy
Copy link
Contributor

Would you accept PRs on some of these conversions for this branch? I'm already dinking around in FlexTable & FlexColumn for work stuff, so if you wouldn't mind, I could take on those methods you have slated for updating in the wiki.

@bvaughn
Copy link
Owner Author

bvaughn commented Apr 29, 2016

Hey @MikeMcElroy! Thanks for the input and the offer to help! That's awesome. :)

I'm working my way through the named parameters this evening. Just finished FlexColumn#cellDataGetter.

I'd be happy to share the load though I wonder if we might step on each other's toes a bit. If you're working this evening, feel free to send me some PRs into this branch- maybe work your way from the bottom of the table up? :)

@bvaughn
Copy link
Owner Author

bvaughn commented Apr 29, 2016

We can chat in Gitter.

bvaughn and others added 21 commits April 28, 2016 21:51
* upstream/version-7:
  Updated signature of InfiniteLoader's :isRowLoaded.
  Updated signature of VirtualScroll's :rowHeight function.
  Updated signature for VirtualScroll's :rowRenderer
Implement named parameters in certain functions and clean up
@bvaughn
Copy link
Owner Author

bvaughn commented May 9, 2016

FYI @MoOx~ I've just published version 7.0.0-rc.1 to NPM. I'd like to do more performance testing before a final release candidate, but this should let you start using the changes I've done so far if you'd like.

@bvaughn
Copy link
Owner Author

bvaughn commented May 9, 2016

Performance tests aren't showing anything alarming- but it's gotten too late to feel comfortable with a release. Look for 7.0 in the morning. :)

@bvaughn bvaughn merged commit eddf198 into master May 9, 2016
@bvaughn bvaughn deleted the version-7 branch May 9, 2016 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants