Skip to content

Conversation

@dicej
Copy link
Contributor

@dicej dicej commented Oct 8, 2024

Add support for the Component Model Async ABI to wasm-tools, wit-bindgen, and wasmtime.

Rendered RFC

Copy link
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! 🥳

From a brief skim, the parts of this that I'm qualified to have an opinion on all look good to me. I left a couple of inline comments on specific aspects, but they're not particularly important.

dicej added 2 commits October 8, 2024 11:34
- Simplify `AsyncConfig` for the guest binding generator
- Focus on API and implementation topics in the `Rationale and alternatives` section

Signed-off-by: Joel Dice <[email protected]>
Signed-off-by: Joel Dice <[email protected]>
@dicej dicej merged commit 0d7f0fc into bytecodealliance:main Oct 8, 2024
@dicej
Copy link
Contributor Author

dicej commented Oct 8, 2024

Ugh, I definitely did not mean to merge this. I must have pushed to origin/main by mistake. Sorry; will revert.

@dicej
Copy link
Contributor Author

dicej commented Oct 8, 2024

I've reverted all the earlier commits, rebased, and opened #38 -- please direct further discussion there. Sorry again for the confusion!

BTW, would it make sense to tweak the branch protection rules in this repo to block pushing straight to main? Asking for a friend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants