build: Use temporary file for can_compile #1497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The can_compile function in build.rs previously invoked rustc with -o -, which causes rustc to attempt to create a temporary metadata directory in the current working directory. When building with Portage for ChromeOS, this happens in a sandbox where the current working directory is not writeable, resulting in a sandbox access violation. This change modifies the can_compile function to use a temporary directory for the output file. This forces rustc to create the temporary file in a writeable location, avoiding the sandbox issue.
|
Thanks! |
|
This is now released in rustix 1.1.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
can_compilefunction in build.rs previously invokedrustcwith-o -, which causesrustcto attempt to create a temporary metadata directory in the current working directory.When building this in another build system such as Portage, this happens in a sandbox where the current working directory is not writeable, resulting in a sandbox access violation.
This change modifies the
can_compilefunction to use a temporary directory for the output file. This forcesrustcto create the temporary file in a writeable location, avoiding the sandbox issue.