Turn warnings into errors in CI #4397
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lum1n0us
commented
Jun 20, 2025
lum1n0us
commented
- Apply global warnings in config_common.cmake instead of maintaining them in separate files.
- Enable errors during CI when building iwasm and wamrc
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
8 times, most recently
from
f5a4210 to
b1a3ca5
Compare
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
from
f553bd8 to
c3cb9e0
Compare
lum1n0us
requested review from
loganek,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
loganek
reviewed
Jul 1, 2025
yamt
reviewed
Jul 3, 2025
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
from
c3cb9e0 to
3eaf5a9
Compare
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
2 times, most recently
from
02eaa53 to
0050677
Compare
lum1n0us
added
the
enhancement
TianlongLiang
approved these changes
Jul 29, 2025
lum1n0us
added
breaking-change
yamt
reviewed
Aug 19, 2025
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
from
0050677 to
b5eea46
Compare
|
depends on #4582 |
- Apply global warnings in warnings.cmake instead of maintaining them in separate files. - Enable errors during CI when building iwasm and wamrc. - Since GCC and Clang are the default compilers on Ubuntu and macOS, enabling `-Werror` on both platforms can be treated as checking with different compilers.
lum1n0us
force-pushed
the
fix/global_wanring_options
branch
from
f37b8aa to
c000ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.