Skip to content

408 cleanup #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

408 cleanup #436

wants to merge 16 commits into from

Conversation

FardaleM
Copy link
Collaborator

Removing function that are always present in 4.08.

@c-cube
Copy link
Owner

c-cube commented Jul 27, 2023

looks nice so far :)

@c-cube c-cube force-pushed the main branch 2 times, most recently from e4c484d to 60bb2c8 Compare December 20, 2023 19:41
@FardaleM
CCFun(cleanup): align CCFun.compose with the stdlib
2aa8416 
Conditionally define CCFun.compose and align its definition with the
stdlib. The arguments are now swapped.
@FardaleM
CCFormat(feat): add option and result, change opt
1de3036 
Add CCFormat.option and CCFormat.result as aliases to
Format.pp_print_option and Format.pp_print_result. Make CCFormat.opt an
alias of CCFormat.option, as such this add an optional argument to print
the case "None" but change the default behaviour. Previously, it as
printing "some _" or "none" now it print something only in the case of
"Some x" and just "x".
@c-cube
Copy link
Owner

c-cube commented Dec 25, 2024

I really don't think we should break compose 😅

Maybe we can deprecate it, add a new name for it that doesn't clash, and we remove it in 4.00.

@FardaleM
Copy link
Collaborator Author

FardaleM commented Dec 25, 2024 •
edited
Loading

(I will edit this list as I go through the modules)
Here is a list of things that need to be decided one:

  • ListLabel.init takes the length as a named argument, do we want to to do the same
  • Fun.compose have inverted argument, should we change to do the same
  • ListLabel.compare and ListLabel.equal take the function on element as named arguments, should we change to do the same
  • List.partition_map correspond to CCList.partition_map_either and not to the current CCList.partition_map, should we change to match the stdlib?
  • List.assoc does not take the equality function as argument, we could change the label argument with an optional one to match the stdlib
  • List.sort_uniq does not take the cmp function as labeled arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FardaleM @c-cube