Skip to content

Conversation

@panthony
Copy link
Contributor

I had a huge performance regression for normalized stack bar when I have a thousand bar and ~10 series.

It makes the browser hang for a while, stuck in 'filterTargetsToShow' mainly.

When I investigated I found that:

  • the calls to 'api.data.shown' seems unnecessary.
  • we normalized values for a lot of unnecessary targets. Like a LOT, coupled with the fact that 'filterTargetsToShow' were copying the targets it had a huge hit

@panthony panthony force-pushed the patch/18-getRatio-perf branch from 1565430 to 115cb29 Compare September 11, 2019 13:59
@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

Merging #2699 into master will decrease coverage by 0.04%.
The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.05%     
==========================================
  Files          59       59              
  Lines        4718     4724       +6     
==========================================
+ Hits         3901     3904       +3     
- Misses        817      820       +3
Impacted Files Coverage Δ
src/shape.js 95.52% <100%> (+0.13%) ⬆️
src/data.js 88.34% <83.33%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dcd65...115cb29. Read the comment docs.

@panthony panthony marked this pull request as ready for review September 17, 2019 12:19
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.64%. Comparing base (93dcd65) to head (115cb29).
⚠️ Report is 93 commits behind head on master.

Files with missing lines Patch % Lines
src/data.js 83.33% 3 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.05%     
==========================================
  Files          59       59              
  Lines        4718     4724       +6     
==========================================
+ Hits         3901     3904       +3     
- Misses        817      820       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants