Skip to content

feat(adapter/sfml): added build for SFML adapter #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat(adapter/sfml): added build for SFML adapter #48

wants to merge 6 commits into from

Conversation

gabrielcolson
Copy link
Member

@gabrielcolson gabrielcolson commented Apr 18, 2021 •
edited
Loading

How to test:

Clone the SFML tennis example

go build -tags prod
mv c3pm $GOPATH/bin/c3pm
cd /tmp/SFML/examples/tennis
c3pm init --no-template
c3pm add sfml
c3pm build
./tennis

@gabrielcolson gabrielcolson self-assigned this Apr 18, 2021
@gabrielcolson gabrielcolson marked this pull request as ready for review May 11, 2021 17:49
@chloebourbion chloebourbion marked this pull request as draft June 20, 2021 16:57
@gabrielcolson gabrielcolson marked this pull request as ready for review June 20, 2021 16:57
@gabrielcolson gabrielcolson marked this pull request as draft June 20, 2021 16:57
Codelax
Codelax reviewed Jul 12, 2021
View reviewed changes
adapter/sfml/sfml.go
"CMAKE_RUNTIME_OUTPUT_DIRECTORY": pc.ProjectRoot,
"CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE": pc.ProjectRoot,
"CMAKE_BUILD_TYPE": "Release",
"BUILD_SHARED_LIB": "OFF",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"BUILD_SHARED_LIB": "OFF",
"BUILD_SHARED_LIBS": "OFF",

'S' is missing, as seen in https://www.sfml-dev.org/tutorials/2.5/compile-with-cmake.php

@ClementDBS ClementDBS removed their request for review April 17, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Codelax Codelax Codelax left review comments

@angela-hubner angela-hubner Awaiting requested review from angela-hubner

@Oursin Oursin Awaiting requested review from Oursin

At least 1 approving review is required to merge this pull request.

Assignees

@gabrielcolson gabrielcolson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielcolson @Codelax