Skip to content

Break long poll loop early when context remaining timeout is too low #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Break long poll loop early when context remaining timeout is too low #1123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab3d43f
Break long poll loop early when context remaining timeout is too low
vytautas-karpavicius Aug 26, 2021
58c5f95
Merge branch 'master' into get-workflow-history-context-done
vytautas-karpavicius Aug 31, 2021
5d3ea6f
Merge branch 'master' into get-workflow-history-context-done
meiliang86 Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/internal_workflow_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ var _ DomainClient = (*domainClient)(nil)
const (
defaultDecisionTaskTimeoutInSecs = 10
defaultGetHistoryTimeoutInSecs = 25
minLongPollInterval = 100 * time.Millisecond
)

var (
Expand Down Expand Up @@ -512,6 +513,15 @@ func (wc *workflowClient) GetWorkflowHistory(
var err error
Loop:
for {
// Stop polling the server if the remaining context timeout is too low.
// This prevents unnessesary final call which will result in a timeout anyway.
if deadline, ok := ctx.Deadline(); ok {
remainingTime := deadline.Sub(time.Now())
if remainingTime < minLongPollInterval {
return nil, context.DeadlineExceeded
}
}

err = backoff.Retry(ctx,
func() error {
var err1 error
Expand Down