Move cadence server's app to common #6909
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arzonus
force-pushed
the
move-cadence-server-run-to-common
branch
from
9c5effd to
94ea973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
fx.Appof cadence server has been moved tocommon/service/cadencepackageRunMultipleServiceshas been moved tocommon/util/fxpackageWhy?
To introduce a command that runs all cadence services with one command in the CLI, we need to reuse existing functionality that's private one. So it requires making them public, and be able to be shared across different packages.
How did you test it?
Potential risks
Release notes
Documentation Changes