Skip to content

5.x - Simpler check constraints #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open

5.x - Simpler check constraints #932

wants to merge 2 commits into from

Conversation

@markstory
Copy link
Member

  • Simplify migrations code around check constraints as we can use cakephp/database now.
  • Expand tests for sqlite and postgres.
  • Fix incorrect logic in sqlite implementation.

@markstory
Simplify CheckConstraint and expand tests
4bbbce3 
- With CheckConstraint in cakephp/database we don't need as much code in
  migrations.
- Fix SQLite implementation.
- Add test coverage for sqlite + postgres.
@markstory
Remove reflection logic and use cakephp/database
eeef6f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.x (CakePHP 5.x, builtin-backend)

Development

Successfully merging this pull request may close these issues.

2 participants

@markstory