feat: add method to deallocate reactNativeFactory instance for iOS #137
+58
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return | ||
| } | ||
|
|
||
| guard let factory = reactNativeFactory else { return } |
There was a problem hiding this comment.
Suggested change
| guard let factory = reactNativeFactory else { return } | |
| guard let reactNativeFactory else { return } |
Comment on lines
+35
to
+40
| private func checkFactoryInitialized(launchOptions: [AnyHashable: Any]? = nil) { | ||
| if reactNativeFactory == nil { | ||
| delegate.dependencyProvider = RCTAppDependencyProvider() | ||
| self.reactNativeFactory = RCTReactNativeFactory(delegate: delegate) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we create w getter on the factory that initizalizes it if it's nil? It should remove the need to call this function
Comment on lines
+157
to
+162
| factory.bridge?.invalidate() | ||
|
|
||
| NotificationCenter.default.removeObserver(self) | ||
| onBundleLoaded = nil | ||
|
|
||
| reactNativeFactory = nil |
There was a problem hiding this comment.
Did you test the scenario of what happens when react native view is still shown while calling this? Let's make sure it doesn't crash the app.
There was a problem hiding this comment.
Maybe there is a way to detect current react native surfaces in the app and show a warning if the user tries to do this with views still on screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RCTHost).checkFactoryInitialized()and uses it inview()to re-create the factory on demand if it was stopped.ReactNativeViewControllernow guards against anilview with a safe placeholder, avoiding SwiftUI bridging crashes.rootViewFactoryto avoid retaining the old runtime.startReactNative()API remains;view()now self‑heals if RN was previously stopped.Test plan
stopReactNativecalled before RN was initialize)