Skip to content

fix: Update accessibilityValue handling in ProgressBar to also use the animatedValue #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KevinvdBurg
Copy link

Set the accessibilityValue if animatedValue is set.

Motivation

We noticed that the accessibilityValue is probably not set when only setting the animatedValue. Because the progress and animatedValue should not be used in parallel, we can see here that animatedValue is ignored by the accessibilityValue.

    accessibilityValue={
      indeterminate
        ? {}
        : { min: 0, max: 100, now: Math.round(progress * 100) }
    }

Related issue

n.a.

Test plan

I added tests to check the accessibilitValue of the ProgressBar.

@callstack-bot
Copy link

Hey @KevinvdBurg, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants