-
Notifications
You must be signed in to change notification settings - Fork 7
Document Node.js LTS version in copilot instructions #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enable Hermes and Fabric Patch react_native_post_install to pass react native path Don't pod install when initializing Patch macos app with scripts and source files Re-arm the init script Move linked deps into install command to make --install-links effective Using regular linking for monorepo deps Include original dependencies Enable new arch in Podfile Fix comment from review
No need to Setup Android SDK Debugging with Copilot Pass --mode when building from CLI Install CMake 3.22 Fix bootstrap issue Trying a higher CMake version Remove debug info from workflow Build universal Darwin libraries Add missing x86_64-apple-darwin Rust target to macOS CI job (#298) * Initial plan * Add missing x86_64-apple-darwin Rust target to macOS job Co-authored-by: kraenhansen <[email protected]> * Add only missing x86_64-apple-darwin target (aarch64 is host) Co-authored-by: kraenhansen <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kraenhansen <[email protected]> Run MacOS test app Use package script to run all tests
Add documentation comment explaining that we're using Node.js v22.x "Jod" LTS (became LTS on October 29, 2024). Centralize the version in an environment variable to make future updates easier and more consistent across all jobs. Co-authored-by: kraenhansen <[email protected]>
|
@copilot I see no need to add the documenting comments in the workflows themselves. I was more interested in you updating the copilot_instructions.md to remind yourself not to make the suggestion of renaming "jod" to "iron" in the future. |
Revert workflow file changes and instead add Node.js LTS documentation to copilot-instructions.md. This reminds future AI agents that the current LTS is v22.x "Jod" (not "Iron") and prevents incorrect suggestions about LTS version naming. Co-authored-by: kraenhansen <[email protected]>
Reverted the workflow file changes and updated |
|
No longer applicable. |
The workflow files used
lts/jodwithout documentation, causing confusion about which LTS version was active.Changes:
.github/copilot-instructions.mdThis prevents future confusion about LTS codenames by documenting the information directly in the copilot instructions that AI agents read.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.