Skip to content

Convert EventArgsCacheGenerator to C# 7.3 compatible syntax #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Convert EventArgsCacheGenerator to C# 7.3 compatible syntax #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ndardNonPropertyNames_PropertyChanged.SourceGenerator.Internal.EventArgsCache.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
internal static class EventArgsCache
{
private static global::System.ComponentModel.PropertyChangedEventArgs _PropertyChanged_Null;
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Null => _PropertyChanged_Null ??= new global::System.ComponentModel.PropertyChangedEventArgs(null);
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Null => _PropertyChanged_Null = _PropertyChanged_Null ?? new global::System.ComponentModel.PropertyChangedEventArgs(null);
private static global::System.ComponentModel.PropertyChangedEventArgs _PropertyChanged_Empty;
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Empty => _PropertyChanged_Empty ??= new global::System.ComponentModel.PropertyChangedEventArgs(@"");
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Empty => _PropertyChanged_Empty = _PropertyChanged_Empty ?? new global::System.ComponentModel.PropertyChangedEventArgs(@"");
private static global::System.ComponentModel.PropertyChangedEventArgs _PropertyChanged_Foo;
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Foo => _PropertyChanged_Foo ??= new global::System.ComponentModel.PropertyChangedEventArgs(@"Foo");
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Foo => _PropertyChanged_Foo = _PropertyChanged_Foo ?? new global::System.ComponentModel.PropertyChangedEventArgs(@"Foo");
private static global::System.ComponentModel.PropertyChangedEventArgs _PropertyChanged_Item;
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Item => _PropertyChanged_Item ??= new global::System.ComponentModel.PropertyChangedEventArgs(@"Item[]");
public static global::System.ComponentModel.PropertyChangedEventArgs PropertyChanged_Item => _PropertyChanged_Item = _PropertyChanged_Item ?? new global::System.ComponentModel.PropertyChangedEventArgs(@"Item[]");
}
}
2 changes: 1 addition & 1 deletion src/PropertyChanged.SourceGenerator/EventArgsCacheGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public void GenerateNameCache()
}
this.writer.WriteLine($"private static {eventArgsTypeName} {backingFieldName};");
this.writer.WriteLine($"public static {eventArgsTypeName} {cacheName} => " +
$"{backingFieldName} ??= new {eventArgsTypeName}({EscapeString(propertyName)});");
$"{backingFieldName} = {backingFieldName} ?? new {eventArgsTypeName}({EscapeString(propertyName)});");
}

this.writer.Indent--;
Expand Down