Change ActiveEntityModifier to ActiveEntityModifierFlattener #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisajulia
force-pushed
the
fix-deletion-error
branch
from
182c2e2 to
6a0abf7
Compare
beckermarc
reviewed
Nov 6, 2025
...java/com/sap/cds/feature/attachments/handler/draftservice/DraftCancelAttachmentsHandler.java
Outdated
Show resolved
Hide resolved
lisajulia
force-pushed
the
fix-deletion-error
branch
2 times, most recently
from
6ece6a4 to
e25344a
Compare
lisajulia
force-pushed
the
fix-deletion-error
branch
2 times, most recently
from
16e0372 to
e8d63f6
Compare
lisajulia
changed the title
This is used in the DraftCancelAttachmentsHandler to construct SELECT queries
from a DELETE statement, when
"fiori": {
"draft_messages": true
}
then the UI sends refs with multiple segments which we transform to a working
SELECT statement with the ActiveEntityModifierFlattener.
lisajulia
force-pushed
the
fix-deletion-error
branch
from
e8d63f6 to
7f493ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR possibly fixes: #526
The ActiveEntityModifierFlattener is used in the DraftCancelAttachmentsHandler to construct SELECT queries
from a DELETE statement. The problem was: when
"fiori": {
"draft_messages": true
}
then the UI sends refs with multiple segments which are transformed to a working
SELECT statement with the ActiveEntityModifierFlattener.
I've also added a comment to the method DraftCancelAttachmentsHandler:isWhereEmpty; this function verifies that we are really cancelling a draft and not doing sth else.
I'm not entirely sure if this function is returning the correct value for the SDM plugin, for cds-feature-attachments it is behaving correctly as far as I can tell now.