Skip to content

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Sep 1, 2025

These common styles, when applied, where getting a specificity of 1 class and 1 tag. This change lowers the specificity to match Carbon default type styling using :where() to wrap the class selector.

@lee-chase lee-chase requested a review from rodet as a code owner September 1, 2025 13:42
@lee-chase lee-chase marked this pull request as draft September 1, 2025 13:45
@lee-chase

This comment was marked as resolved.

@lee-chase lee-chase marked this pull request as ready for review September 2, 2025 15:27
rodet
rodet previously requested changes Sep 26, 2025
Copy link
Contributor

@rodet rodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clear the overflow first and then we can proceed, I have only this finding. Thanks for the good commenting overall.

@lee-chase lee-chase force-pushed the lowerCommonPageSpecificity branch from e7d60ea to b1c9e7c Compare September 29, 2025 16:14
@lee-chase lee-chase requested a review from rodet September 29, 2025 16:19
@lee-chase lee-chase dismissed rodet’s stale review September 29, 2025 16:42

Discussed via teams

@lee-chase lee-chase merged commit f94a3ca into main Sep 29, 2025
5 checks passed
@lee-chase lee-chase deleted the lowerCommonPageSpecificity branch September 29, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants