-
Notifications
You must be signed in to change notification settings - Fork 10
fix: increase pruning interval #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
store.utxo.pruning-interval=600 | ||
store.utxo.pruning-interval=3600 | ||
store.utxo.pruning-batch-size=${REMOVE_SPENT_UTXOS_BATCH_SIZE:3000} | ||
logging.level.com.bloxbean.cardano.yaci.store=${LOG:error} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should not be necessary actually, confusing. I wouldn't do this, it should take root logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The LOG env variable is the already existing. The logging was just added as we were not seeing the Yaci-indexer pruning logs and it needed to be turned to debug to see the logs. Could you clarify, is LOG env variable not root logging option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small issues
10 minute interval for pruning is too aggressive and it causes very high I/O when syncing. Increasing it to 1 hour.
Rationale -
configure option for pruning batch size. Default is 3000 but if needed can be changed upto 10000 for faster deletion but it should not cause too much I/O while syncing
debug option for utxo store