Replace deprecated Aws::S3::Object#upload_file with TransferManager #191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation uses the deprecated
Aws::S3::Object#upload_filemethod, which triggers this warning:Additionally, this causes the first file upload to fail when starting the application or a background task. Subsequent uploads work correctly, but the initial failure is problematic for production environments.
Fixes #190
Changes
CarrierWave::Storage::AWSFile#storeto useAws::S3::TransferManagerMULTIPART_THRESHOLD)TransferManagerMetrics/ClassLengthin.rubocop.ymlfrom 102 to 105 lines to maintain code readabilityTesting
All existing tests pass:
Compatibility
This change maintains backward compatibility while ensuring compatibility with future AWS SDK versions.