Skip to content

Fix operation in strict mode #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ska-kialo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix operation in strict mode #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34861,6 +34861,7 @@ Cogs.define("react-list.js", function (COGS_REQUIRE, COGS_REQUIRE_ASYNC, module,
window.removeEventListener('resize', this.updateFrameAndClearCache);
this.scrollParent.removeEventListener('scroll', this.updateFrameAndClearCache, PASSIVE);
this.scrollParent.removeEventListener('mousewheel', NOOP, PASSIVE);
this.scrollParent = null; // Important to ensure proper setup on second mount in StrictMode
}
}, {
key: "getOffset",
Expand Down
1 change: 1 addition & 0 deletions react-list.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ module.exports = class ReactList extends Component {
PASSIVE
);
this.scrollParent.removeEventListener('mousewheel', NOOP, PASSIVE);
this.scrollParent = null; // Important to ensure proper setup on second mount in StrictMode
}

getOffset(el) {
Expand Down
1 change: 1 addition & 0 deletions react-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@
window.removeEventListener('resize', this.updateFrameAndClearCache);
this.scrollParent.removeEventListener('scroll', this.updateFrameAndClearCache, PASSIVE);
this.scrollParent.removeEventListener('mousewheel', NOOP, PASSIVE);
this.scrollParent = null; // Important to ensure proper setup on second mount in StrictMode
}
}, {
key: "getOffset",
Expand Down