Remove ActionScope.threadLocalUUID #3188
Open
+24
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shouldn't be merged until the deprecated
ActionScope::entermethod is deleted. Otherwise it will break existing callers who use a direct executorThis removes the ThreadLocal UUID and simplifies the code, fixing what I believe is an unintended behavior and a footgun. Currently you can overwrite your ActionScope seed data if you propagate an ActionScope to a "new" thread using a DirectExecutor. Because the UUID will match, it won't complain about being in an action scope and happily overwrite the thread local with the newly supplied seed data. Now that we have ActionScope.Instance, we can check for object equality and provide the safer guarantee that the scope you're propagating is the same as the current scope.