Add support for managing attachments #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callum027
force-pushed
the
callum/add-attachment-support
branch
5 times, most recently
from
000bab3 to
f244d13
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
2 times, most recently
from
cca47cd to
b7cfe9e
Compare
Callum027
force-pushed
the
callum/add-update-method
branch
from
542f3b7 to
a9d224b
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
2 times, most recently
from
0a55a89 to
49c5b88
Compare
Callum027
force-pushed
the
callum/add-update-method
branch
from
a9d224b to
24c7ad7
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
3 times, most recently
from
10e56b7 to
bbb9adb
Compare
Callum027
force-pushed
the
callum/add-update-method
branch
from
24c7ad7 to
763759f
Compare
Callum027
force-pushed
the
callum/add-attachment-support
branch
2 times, most recently
from
72cbf6d to
bbbe041
Compare
Callum027
commented
Oct 17, 2025
|
|
||
|
|
||
| class Product(RecordBase["ProductManager"]): | ||
| active: bool |
Collaborator
Author
There was a problem hiding this comment.
Move to a separate PR.
Callum027
force-pushed
the
callum/add-attachment-support
branch
from
bbbe041 to
2f9cd30
Compare
Callum027
commented
Oct 21, 2025
Comment on lines
+395
to
+396
| attr_type_origin = get_type_origin(attr_type) | ||
| if attr_type_origin is Union or attr_type_origin is UnionType: |
Collaborator
Author
There was a problem hiding this comment.
Move to a separate PR.
Callum027
force-pushed
the
callum/add-attachment-support
branch
2 times, most recently
from
134c44b to
43aa7c6
Compare
Add a new manager for attachment records (`ir.attachment`) in Odoo. These are intended to be used for uploading/downloading attachments to/from invoices. Invoice attachments will then be attached to invoice emails sent out to customers. The contents of the attachments won't be fetched when querying them from Odoo by default; instead it is intended that the separate `download` method be used to download the attachment contents separately. An `upload` method is also available, to provide an easier to use interface for uploading attachments.
Callum027
force-pushed
the
callum/add-attachment-support
branch
from
43aa7c6 to
025f474
Compare
Contributor
|
Looks good - the docs are especially good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new manager for attachment records (
ir.attachment) in Odoo.These are intended to be used for uploading/downloading attachments to/from invoices. Invoice attachments will then be attached to invoice emails sent out to customers.
The contents of the attachments won't be fetched when querying them from Odoo by default; instead it is intended that the separate
downloadmethod be used to download the attachment contents separately. Anuploadmethod is also available, to provide an easier to use interface for uploading attachments.