Skip to content

Adding node 22 and 24 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

Adding node 22 and 24 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-ubuntu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
IMAGE_LABEL_REPO: ${{ github.repository }}
SLUG: ${{ github.repository_owner }}/ubuntu
DISTRO: ubuntu
NODE: '16 18 20'
NODE: '16 18 20 22 24' # 24 is the default
BUILD_REF: ${{ github.sha }}
SKIP_TEST: false
PUSH_GHCR: ${{ github.repository == (github.event.pull_request.head.repo.full_name || github.repository) && '1' || '' }}
Expand Down
2 changes: 1 addition & 1 deletion linux/ubuntu/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ ARG FROM_TAG

# > Our custom ARGs
# latest Node.js LTS versions
ARG NODE_VERSION="16 18"
ARG NODE_VERSION="16 18 20 22" # v24 is installed in js.sh
ARG DISTRO=ubuntu
ARG TYPE=act
ARG RUNNER
Expand Down
4 changes: 2 additions & 2 deletions linux/ubuntu/scripts/js.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" # This loads nvm' | tee
printf "\n\t🐋 Installed NVM 🐋\t\n"
nvm --version

# node 16 and 18 are already installed in act-*
versions=("20")
# node 16, 18, 20 and 22 are already installed in act-*
versions=("24")
JSON=$(wget -qO- https://nodejs.org/download/release/index.json | jq --compact-output)

for V in "${versions[@]}"; do
Expand Down