Update avatar URL for a user + refactoring #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add domainname to avatar URL + refactoring so that the URL is now defined on a single location.
app/model/user/User.java
Outdated
| public String setAvatarURL(String userName) | ||
| { | ||
| /* Below URL is of the Crucible ( codereview ) server */ | ||
| this.avatarURL = "http://srv-ind-scrat.vanenburg.com:8060/avatar/" + userName; |
There was a problem hiding this comment.
Shouldn't the ?s=number be part of this code as well? That'd make it trivial to switch to another avatar source (like Jira).
Author
There was a problem hiding this comment.
The required size of the avatar (requested with the ?s=number GET parameter) is dependent on the location where it is used. Currently three times 32, and one time 40.
If you really think it is valuable to make that split right now, maybe 'avatarURLSmall' and avatarURLMedium' or something like that can be introduced for that.
JSONOutputFilter is added because 'stdout' in /job/junitTestJob/1/testReport/api/json ( 'suites[cases[stdout]]]' ) can blow up returned JSON response above 1GB but it is never used
Owner
|
This reverts commit f03348f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add domainname to avatar URL + refactoring so that the URL is now
defined on a single location.