graph: auto rebuild/validation of reverse deps #18
Conversation
This commit introduces the graph modules with class to handle a graph of reverse dependencies between packages in a Rift project. When a package is built, especially when its version has changed, it is important to verify that it does not break build and tests of other packages that depends on it (aka. reverse dependencies). With this new feature, as soon as dependency_tracking option is enabled in project configuration, the graph of reverse dependencies is automatically created with rift build and validate actions, unless --skip-deps option is set on command line. Dependencies are either found in packages info.yaml metadata file or by parsing subpackages (including their provides) and build requirements out of RPM spec files as a fallback. Rift then solves the reverse dependencies of the packages provided by users with build and validate actions to determine the packages that should be rebuilt or validated consequently. Unit tests are added to validate the code introduced for this feature.
rezib
requested review from
qa-cea and
valeriyoann
and removed request for
qa-cea
| Return the first index in result of packages in provided build | ||
| requirements list. |
There was a problem hiding this comment.
suggest: Return the index of the first package in result that appear as a build requirement in new_build_requirements
| @@ -0,0 +1,256 @@ | |||
| # | |||
| # Copyright (C) 2024 CEA | |||
| # Parse buildrequires string in spec file to discard explicit versions | ||
| # enforcement. | ||
| self.build_requires = [ | ||
| value.group(1) | ||
| for value | ||
| in re.finditer(r"(\S+)( (>|>=|=|<=|<) \S+)?", spec.buildrequires) | ||
| ] |
There was a problem hiding this comment.
question: why discard these ? If a package requires another package to be under a certain version, and it gets updated, the build will break right ? So detecting that at update seems a good idea ?
| logging.info(" requires: %s", node.build_requires) | ||
| logging.info(" subpackages: %s", str(node.subpackages)) |
There was a problem hiding this comment.
suggest: switch the two, and replace subpackages with provides
| logging.info(" requires: %s", node.build_requires) | ||
| logging.info(" subpackages: %s", str(node.subpackages)) | ||
| logging.info( | ||
| " rdeps: %s", str([rdep.package.name for rdep in node.rdeps]) |
There was a problem hiding this comment.
suggest: replace rdeps: %s with is required by: %s
| self.config, self.staff, self.modules, args | ||
| ) | ||
| self.assertEqual( | ||
| [pkg.name for pkg in pkgs], ['libone', 'my-software'] |
There was a problem hiding this comment.
question: how did the my-software pkg get here ? It isn't in the list of packages on line 1110
| # return an empty list. | ||
| self.assertEqual(pkgs, []) | ||
|
|
||
| def test_get_packages_to_build_package_order(self): |
There was a problem hiding this comment.
suggest: add another test to verify cyclic dependencies
| @@ -0,0 +1,350 @@ | |||
| # | |||
| # Copyright (C) 2020 CEA | |||
| try: | ||
| package.load() | ||
| except FileNotFoundError as err: | ||
| logging.warning("Skipping package %s unable to load: %s", |
There was a problem hiding this comment.
suggest: add single quotes around the package name to make it easier to read
| """ Test graph dump """ | ||
| pkg_name = 'fake' | ||
| self.make_pkg(name=pkg_name) | ||
| package = Package(pkg_name, self.config, self.staff, self.modules) |
There was a problem hiding this comment.
question: where is this package going to ? The variable is not used in this function, so is the test succeeding because of leftovers from other tests ?
This commit introduces the graph modules with class to handle a graph of reverse dependencies between packages in a Rift project.
When a package is built, especially when its version has changed, it is important to verify that it does not break build and tests of other packages that depends on it (aka. reverse dependencies).
With this new feature, as soon as dependency_tracking option is enabled in project configuration, the graph of reverse dependencies is automatically created with rift build and validate actions, unless --skip-deps option is set on command line. Dependencies are either found in packages info.yaml metadata file or by parsing subpackages (including their provides) and build requirements out of RPM spec files as a fallback.
Rift then solves the reverse dependencies of the packages provided by users with build and validate actions to determine the packages that should be rebuilt or validated consequently.
Unit tests are added to validate the code introduced for this feature.