Replace texfields with jsonfield

[mumarkhan999]

Replacing TextField with JSONField.

Related Issue

• use JSONField instead of TextField #442

[mumarkhan999]

Hi @auvipy,
Could you please review this PR when you get a chance?

[Copilot]

Pull Request Overview

This PR replaces several TextField usages with JSONField in both the TaskResult and ChordCounter models and adjusts migrations to migrate existing data into the new fields, then remove the old ones.

• Models updated: swap out text-based JSON storage for native JSONField on task_args, task_kwargs, meta, and sub_tasks.
• New migrations (0015–0017) copy existing text data into new JSON columns; 0018 removes old fields and renames the new ones.
• Ensures data continuity via batch migrations and bulk updates.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
django_celery_results/models.py	Replaced TextField definitions for task_args, task_kwargs, meta, sub_tasks with JSONField
django_celery_results/migrations/0015_chordcounter_new_sub_tasks_taskresult_new_meta_and_more.py	Added new JSONField columns (new_sub_tasks, new_meta, new_task_args, new_task_kwargs)
django_celery_results/migrations/0016_make_copy_of_taskresult_textfields.py	Populates new TaskResult JSON fields from existing text data in batches
django_celery_results/migrations/0017_make_copy_of_chordcounter_textfields.py	Populates new ChordCounter JSON field from existing text data in batches
django_celery_results/migrations/0018_remove_chordcounter_new_sub_tasks_and_more.py	Drops old text fields and renames new JSONField columns to their original names

Comments suppressed due to low confidence (2)

django_celery_results/models.py:42

• There's no existing test coverage to verify serialization and deserialization of the new JSONField task_args. Consider adding unit tests to ensure it correctly handles various JSON structures (arrays, nested objects, nulls, etc.).

    task_args = models.JSONField(

django_celery_results/models.py:151

• [nitpick] The JSONField sub_tasks lacks a verbose_name argument, unlike the other fields (task_args, task_kwargs, meta). Adding a verbose_name will improve admin UI consistency and clarity.

    sub_tasks = models.JSONField(

[Copilot]

The new JSONField for sub_tasks sets a default of None without null=True, which may cause database constraint errors when existing records are null. Consider adding null=True or providing a valid default (e.g., an empty list) to maintain compatibility.

Suggested change

	default=None,
	null=True,
	default=list,

[auvipy]

why so many schema migration files? can we reduce them? Also the change is not backward compatible as far as I can understand

[mumarkhan999]

Hi @auvipy,

There are total 4 migration files.
Two of them are schema migration files and other two are data migration files.
...
The first migration is to add a new JSONField while keeping the old TextField as it is
The second and third one are to copy data from TextFields to JSONFields.
And the last one is to remove the old TextFields
...
I opted this approach just to keep the old data safe.
The removal of prevous textfields will not be done unless the data has been successfully copied into jsonfield.

[auvipy]

that sounds nice. allow me some time to properly check and review