-
Notifications
You must be signed in to change notification settings - Fork 0
TA-4289: Add command to find staging node #272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| const nodesCommand = configCommand.command("nodes") | ||
| .description("Commands related to staging nodes of the package"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to use this one for the node diff as well? If it does then we should remove the staging keyword here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the diff nodes command should have the structure something like:
content-cli config nodes diff -—packageKey=<pacageKey> --nodeKey=<nodeKey> --baseVersion=<baseVersion> --compareVersion=<compareVersion>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove the staging anyway, since I think it makes sense to use this for versioned nodes too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will remove the staging anyway, since I think it makes sense to use this for versioned nodes too
@ksalihu Does this mean we will add a parameter to this command which determines whether it's staging, prod, or a specific version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, thats how I think is the best structure for these commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Staging node find one
content-cli config nodes find -—packageKey=<pacageKey> --nodeKey=<nodeKey>
Version node find one
content-cli config nodes find -—packageKey=<pacageKey> --nodeKey=<nodeKey> --version=<version>
Node diff one
content-cli config nodes diff -—packageKey=<pacageKey> --nodeKey=<nodeKey> --baseVersion=<baseVersion> --compareVersion=<compareVersion>
What do you think?
DOCUMENTATION.md
Outdated
| #### Finding staging nodes | ||
|
|
||
| The **config nodes find** command allows you to retrieve information about a specific node within a package in the staging environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the staging node keyword from here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also give a section of describing that this is the "staging" Node, in a way or another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, updated the general documentation to not mention staging, but added the command usages to specify that it works on staging nodes
Description
Added new command to find staging node.
Manual tests
content-cli config nodes find --packageKey=3f76540a_1635_401b_94fb_d39a1f8ae67f --nodeKey=3f76540a_1635_401b_94fb_d39a1f8ae67f-view --withConfiguration --jsoncontent-cli config nodes find --packageKey=3f76540a_1635_401b_94fb_d39a1f8ae67f --nodeKey=3f76540a_1635_401b_94fb_d39a1f8ae67f-view --withConfigurationRelevant links
Checklist