Skip to content

Conversation

@ksalihu
Copy link
Contributor

@ksalihu ksalihu commented Oct 22, 2025

Description

Added new command to find staging node.

Manual tests

content-cli config nodes find --packageKey=3f76540a_1635_401b_94fb_d39a1f8ae67f --nodeKey=3f76540a_1635_401b_94fb_d39a1f8ae67f-view --withConfiguration --json
image

content-cli config nodes find --packageKey=3f76540a_1635_401b_94fb_d39a1f8ae67f --nodeKey=3f76540a_1635_401b_94fb_d39a1f8ae67f-view --withConfiguration

image

Relevant links

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@ksalihu ksalihu requested a review from a team as a code owner October 22, 2025 17:42
Comment on lines 72 to 73
const nodesCommand = configCommand.command("nodes")
.description("Commands related to staging nodes of the package");
Copy link

@LendritIbrahimi LendritIbrahimi Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to use this one for the node diff as well? If it does then we should remove the staging keyword here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diff nodes command should have the structure something like:
content-cli config nodes diff -—packageKey=<pacageKey> --nodeKey=<nodeKey> --baseVersion=<baseVersion> --compareVersion=<compareVersion>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove the staging anyway, since I think it makes sense to use this for versioned nodes too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will remove the staging anyway, since I think it makes sense to use this for versioned nodes too

@ksalihu Does this mean we will add a parameter to this command which determines whether it's staging, prod, or a specific version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thats how I think is the best structure for these commands

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging node find one
content-cli config nodes find -—packageKey=<pacageKey> --nodeKey=<nodeKey>
Version node find one
content-cli config nodes find -—packageKey=<pacageKey> --nodeKey=<nodeKey> --version=<version>
Node diff one
content-cli config nodes diff -—packageKey=<pacageKey> --nodeKey=<nodeKey> --baseVersion=<baseVersion> --compareVersion=<compareVersion>

What do you think?

Buqeta
Buqeta previously approved these changes Oct 24, 2025
jetakasabaqi
jetakasabaqi previously approved these changes Oct 24, 2025
DOCUMENTATION.md Outdated
Comment on lines 641 to 643
#### Finding staging nodes

The **config nodes find** command allows you to retrieve information about a specific node within a package in the staging environment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the staging node keyword from here as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also give a section of describing that this is the "staging" Node, in a way or another.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated the general documentation to not mention staging, but added the command usages to specify that it works on staging nodes

@ksalihu ksalihu dismissed stale reviews from jetakasabaqi and Buqeta via 4e54e19 October 24, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants