Skip to content

Conversation

@IssaAlBawwab
Copy link
Member

Updates the record JSON schema to include the definition for the new top-level validated_runs field.

This ensures that all records populated with this new field will validate correctly.

Updates the record JSON schema to include the definition for the new top-level `validated_runs` field.

This ensures that all records populated with this new field will validate correctly.
@psaiz
Copy link
Contributor

psaiz commented Jul 3, 2025

The test that fails is due to the dependencies. Would you mind checking it updating "gevent==25.5.1", in the line 117 of the setup.py fixes the issue?

}
}
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add these fields also to cernopendata/modules/search/component_templates/os-v2/opendata-record-v1.0.0.json, and rename the file to v1.1.0

Updates the record JSON schema to include the definition for the new top-level `validated_runs` field.

This ensures that all records populated with this new field will validate correctly.
@IssaAlBawwab
Copy link
Member Author

The test that fails is due to the dependencies. Would you mind checking it updating "gevent==25.5.1", in the line 117 of the setup.py fixes the issue?

This doesnt fix the issue

IssaAlBawwab and others added 3 commits July 17, 2025 15:42
  - Update greenlet dependency from ==3.0.3 to >=3.2.2 in setup.py
  - Resolves compatibility issue with gevent==25.5.1 requirement
  - Generate missing SSL certificates for nginx service
  - Ensures ./run-tests.sh --check-docker-build passes successfully
@psaiz
Copy link
Contributor

psaiz commented Aug 11, 2025

Hi,
I would recommend rebasing on top of the main branch, where that fix has already been included

@psaiz
Copy link
Contributor

psaiz commented Oct 1, 2025

@IssaAlBawwab, is this one still needed? If so, could you please rebase it? There are conflicts on the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants