feat(api-token): add instance admin token #2657
Open
+347
−184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylwester Piskozub <[email protected]>
Signed-off-by: Sylwester Piskozub <[email protected]>
Signed-off-by: Sylwester Piskozub <[email protected]>
Signed-off-by: Sylwester Piskozub <[email protected]>
Signed-off-by: Sylwester Piskozub <[email protected]>
Signed-off-by: Sylwester Piskozub <[email protected]>
Piskoo
changed the title
Piskoo
changed the title
migmartri
reviewed
Jan 13, 2026
| ALTER TABLE "api_tokens" ALTER COLUMN "organization_id" DROP NOT NULL; | ||
|
|
||
| -- Create index "apitoken_name" to table: "api_tokens" | ||
| CREATE UNIQUE INDEX "apitoken_name" ON "api_tokens" ("name") WHERE ((revoked_at IS NULL) AND (organization_id IS NULL)); |
Member
There was a problem hiding this comment.
Does this mean that now you can have an API token with the same name in the same org?
Collaborator
Author
There was a problem hiding this comment.
No, you can have an instance admin API token with the same name if the other one with the same name was revoked, the same way as org API tokens in here
chainloop/app/controlplane/pkg/data/ent/schema/apitoken.go
Lines 68 to 69 in 4dc6b0a
Signed-off-by: Sylwester Piskozub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for instance admin tokens to existing api token logic
Changes