Skip to content

Conversation

@erwin-wee
Copy link
Collaborator

@erwin-wee erwin-wee commented Nov 5, 2025

Description

  • Add hyperliquid mainnet and testnet support.
  • Add network IDs and erc20 contracts for eth_call method for hyperliquid

Summary by CodeRabbit

  • New Features
    • Added support for Hyperliquid mainnet and testnet networks with associated contract addresses, expanding the set of supported blockchain networks.

@erwin-wee erwin-wee self-assigned this Nov 5, 2025
@erwin-wee erwin-wee added the enhancement New feature or request label Nov 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Walkthrough

Two new Hyperliquid network entries are added to the EvmNetwork.DATA mapping in chainbench/test_data/evm.py: mainnet (chain ID 999) and testnet (chain ID 998), each with a start_block of 1 and their respective ERC-20 contract addresses.

Changes

Cohort / File(s) Change Summary
Network Data Expansion
chainbench/test_data/evm.py
Added two new chain entries to EvmNetwork.DATA: Hyperliquid mainnet (999) with 5 contract addresses and Hyperliquid testnet (998) with 2 contract addresses; both configured with start_block 1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that contract addresses for both Hyperliquid networks are valid and correctly formatted
  • Confirm that chain IDs (999, 998) don't conflict with existing entries in the mapping

Poem

🐰 A hop, skip, and a jump through the blockchain,
New chains arrive—Hyperliquid's reign!
Mainnet, testnet, contracts aligned,
More networks to test, more data refined!

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add hyperliquid support' directly and clearly summarizes the main change in the pull request, which adds support for hyperliquid mainnet and testnet.
Description check ✅ Passed The description includes the 'Description' section with two bullet points detailing the changes, but lacks the 'Issues Resolved' section specified in the template.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/add-hyperliquid-support

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64ae24f and 8c4d096.

📒 Files selected for processing (1)
  • chainbench/test_data/evm.py (1 hunks)
🔇 Additional comments (2)
chainbench/test_data/evm.py (2)

411-418: Chain ID 998 is correct for Hyperliquid testnet.

The chain ID 998 has been confirmed as the official chain ID for Hyperliquid EVM Testnet from Hyperliquid's official documentation, Chainstack reference, and Alchemy RPC listings.

However, I cannot verify the contract addresses through public sources. While Purrsec (testnet.purrsec.com) is a block explorer for the Hyperliquid EVM Testnet that allows searching addresses and contracts, the specific addresses in the code (0x72B0e1c7251511c076c6c7De4864DF06Ec24AC7B and 0x928e4e3dFb1c39a6deE26506Cde76875E3a25ea4) do not appear in publicly accessible sources. You should manually verify these addresses by looking them up on the testnet explorer or confirming their origin within your codebase.


400-410: Verify contract addresses and start_block for Hyperliquid mainnet entry.

The chain ID 999 is confirmed correct for Hyperliquid mainnet. However, please verify the following:

  1. Contract addresses: The address 0x5555555555555555555555555555555555555555 appears to be a vanity/placeholder address and should be verified or replaced. Confirm all five addresses are active ERC-20 token contracts on Hyperliquid mainnet using Hyperevmscan or the Hyperliquid API.
  2. start_block: Using start_block: 1 for mainnet is unusual and differs from other mainnets in this file. Confirm whether this is intentional for Hyperliquid mainnet or if a higher block number is more appropriate.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@erwin-wee erwin-wee merged commit 1c578b6 into main Nov 5, 2025
7 checks passed
@erwin-wee erwin-wee mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants