Skip to content

Conversation

nikparo
Copy link
Contributor

@nikparo nikparo commented Sep 9, 2025

Closes #

📝 Description

Add a brief description

The menu getItemProps and getTriggerProps return normalized props, that then get merged using the core mergeProps function that does not take normalization into account. This is a problem for e.g. Lit, where the event handler prefix is @ rather than on. To properly merge these sets of props in the connect function we need to separate handling of framework-specific and framework-agnostic prop handling.

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

If the normalizeProps function does not use on prefix for event handlers, only the latter is kept.

🚀 New behavior

Please describe the behavior or changes this PR adds

Event handlers are properly merged, as prop normalization happens after the merge.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Copy link

changeset-bot bot commented Sep 9, 2025

🦋 Changeset detected

Latest commit: fe02ca7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 78 packages
Name Type
@zag-js/menu Patch
@zag-js/anatomy-icons Patch
@zag-js/anatomy Patch
@zag-js/core Patch
@zag-js/docs Patch
@zag-js/preact Patch
@zag-js/react Patch
@zag-js/solid Patch
@zag-js/svelte Patch
@zag-js/vue Patch
@zag-js/accordion Patch
@zag-js/angle-slider Patch
@zag-js/async-list Patch
@zag-js/avatar Patch
@zag-js/bottom-sheet Patch
@zag-js/carousel Patch
@zag-js/checkbox Patch
@zag-js/clipboard Patch
@zag-js/collapsible Patch
@zag-js/color-picker Patch
@zag-js/combobox Patch
@zag-js/date-picker Patch
@zag-js/dialog Patch
@zag-js/editable Patch
@zag-js/file-upload Patch
@zag-js/floating-panel Patch
@zag-js/hover-card Patch
@zag-js/listbox Patch
@zag-js/navigation-menu Patch
@zag-js/number-input Patch
@zag-js/pagination Patch
@zag-js/password-input Patch
@zag-js/pin-input Patch
@zag-js/popover Patch
@zag-js/presence Patch
@zag-js/progress Patch
@zag-js/qr-code Patch
@zag-js/radio-group Patch
@zag-js/rating-group Patch
@zag-js/scroll-area Patch
@zag-js/select Patch
@zag-js/signature-pad Patch
@zag-js/slider Patch
@zag-js/splitter Patch
@zag-js/steps Patch
@zag-js/switch Patch
@zag-js/tabs Patch
@zag-js/tags-input Patch
@zag-js/timer Patch
@zag-js/toast Patch
@zag-js/toggle-group Patch
@zag-js/toggle Patch
@zag-js/tooltip Patch
@zag-js/tour Patch
@zag-js/tree-view Patch
@zag-js/store Patch
@zag-js/types Patch
@zag-js/aria-hidden Patch
@zag-js/auto-resize Patch
@zag-js/collection Patch
@zag-js/color-utils Patch
@zag-js/utils Patch
@zag-js/date-utils Patch
@zag-js/dismissable Patch
@zag-js/dom-query Patch
@zag-js/file-utils Patch
@zag-js/focus-trap Patch
@zag-js/focus-visible Patch
@zag-js/highlight-word Patch
@zag-js/i18n-utils Patch
@zag-js/interact-outside Patch
@zag-js/json-tree-utils Patch
@zag-js/live-region Patch
@zag-js/popper Patch
@zag-js/rect-utils Patch
@zag-js/remove-scroll Patch
@zag-js/scroll-snap Patch
@zag-js/stringify-state Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
zag-nextjs Ready Ready Preview Sep 16, 2025 7:45pm
zag-solid Ready Ready Preview Sep 16, 2025 7:45pm
zag-svelte Ready Ready Preview Sep 16, 2025 7:45pm
zag-vue Ready Ready Preview Sep 16, 2025 7:45pm
zag-website Ready Ready Preview Sep 16, 2025 7:45pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant