libgenders: deprecate genders_getmaxattrs() #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The genders_getmaxattrs() function returns a value that requires the genders database to be parsed in a very specific way. It does not give much leniency to parsing other ways or using different internal data structures. In addition, the value is not used in expected places such as genders_attrlist_create(). Deprecate genders_getmaxattrs(). Have it call genders_getnumattrs() instead. Internally remove all "maxattrs" appropriate calculations. Deprecate associated extensions of genders_getmaxattrs().
Problem: Now that genders_getmaxattrs() returns the value from genders_getnumattrs() some tests fail. Update failing tests.
Problem: Now that genders_getmaxattrs() has been deprecated it should be removed from documentation. Remove all references to genders_getmaxattrs() notes in manpages.
Problem: There have been Makefile.am changes. The build system needs to be regenerated. Run ./autogen.sh to regenerate everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.