libgenders: fix numnodes calculation #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The numnodes are calculated before hostlist_uniq() is called, which can lead to an invalid calculation when calling hostlist_count(). Move the calculation of numnodes to after hostlist_uniq() is called. Fixes chaos#87
Problem: There is no coverage to ensure the miscalculation in issue87 is tested. Add test in testsuite/libgenders.
Problem: There are very few tests that cover "mixed up" genders nodes in a file, i.e. nodes listed on multiple lines. Add coverage to testsuite/libgenders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The numnodes are calculated before hostlist_uniq() is
called, which can lead to an invalid calculation when calling
hostlist_count().
Move the calculation of numnodes to after hostlist_uniq() is called.