Skip to content

Conversation

hendrikKahl
Copy link
Contributor

@hendrikKahl hendrikKahl commented Oct 7, 2020

Hi,

this is a copy of PR #89, but as request it has a clean history with rebase instead of merge commits.

This PR would add a return value to the terminate_pods action. I found it quite helpful to get this kind of information persisted in the journal.json document for future reference and further analysis. It would also address #60 .

Since it seems only the return value (or exception) of an action will be stored, I would suggest to store the already available pod names in an array and return it.

Tests have been enhanced to include checks of the return value.

Looking forward to get some thoughts on this suggestion.

Cheers, Hendrik

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@cb77bc1). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   81.72%           
=========================================
  Files             ?       13           
  Lines             ?      766           
  Branches          ?        0           
=========================================
  Hits              ?      626           
  Misses            ?      140           
  Partials          ?        0           
Impacted Files Coverage Δ
chaosk8s/pod/actions.py 95.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb77bc1...4416558. Read the comment docs.

@Lawouach Lawouach merged commit 935b57c into chaostoolkit:master Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants