Skip to content

Use the sender name in the title for Push Notifications instead of the recipient's name #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use the sender name in the title for Push Notifications instead of the recipient's name #453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6336181
Update index.js
muhammadsr Dec 23, 2018
f64a6f8
Update FirebasePushHandler.java
muhammadsr Dec 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions FirebasePushNotifications/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ exports.pushToChannels = functions.https.onCall((data, context) => {

let type = data.type;
let senderId = String(data.senderId);
let senderName = data.senderName ? data.senderName : 'You received a message';
let threadId = String(data.threadId);

let userIds = data.userIds;
Expand All @@ -187,8 +188,7 @@ exports.pushToChannels = functions.https.onCall((data, context) => {
var status = {};
for(let uid in userIds) {
if(userIds.hasOwnProperty(uid)) {
let userName = userIds[uid];
let message = buildMessage(userName, body, action, sound, type, senderId, threadId, uid);
let message = buildMessage(senderName, body, action, sound, type, senderId, threadId, uid);
status[uid] = message;
admin.messaging().send(message);
}
Expand All @@ -203,7 +203,6 @@ exports.pushListener = functions.database.ref('{rootPath}/threads/{threadId}/mes

let messageValue = messageSnapshot.val();
let senderId = messageValue["user-firebase-id"];

let pushRef = admin.database().ref(context.params.rootPath).child("push-test");

let threadId = context.params.threadId;
Expand Down Expand Up @@ -232,4 +231,4 @@ exports.pushListener = functions.database.ref('{rootPath}/threads/{threadId}/mes
});
});

});
});
1 change: 1 addition & 0 deletions chat-sdk-firebase-push/src/main/java/co/chatsdk/firebase/push/FirebasePushHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public void pushForMessage (Message message) {
data.put("userIds", users);
data.put("body", body);
data.put("type", message.getType());
data.put("senderName", message.getSender().getName());
data.put("senderId", message.getSender().getEntityID());
data.put("threadId", message.getThread().getEntityID());
data.put("action", ChatSDK.config().pushNotificationAction != null ? ChatSDK.config().pushNotificationAction : QuickReplyNotificationCategory);
Expand Down