dc_array: panic on null pointers and out of range indexes #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAction
reviewed
Aug 11, 2019
| (*array).get_ptr(index) | ||
| } | ||
| assert!(!array.is_null()); | ||
| (*array).get_ptr(index) |
There was a problem hiding this comment.
Here you remove index >= (*array).len() check.
There was a problem hiding this comment.
get_ptr() does this check. It is safe, actually.
link2xt
changed the title
|
WIP as I want to rebase it on top of #334 |
link2xt
changed the title
Jikstra
suggested changes
Aug 13, 2019
| } else { | ||
| (*array).get_uint(index) | ||
| } | ||
| assert!(!array.is_null()); |
There was a problem hiding this comment.
Panicing on a null pointer changes the behaviour of the ffi, i think we should avoid this. If it's null, we should return a 0
There was a problem hiding this comment.
@r10s what do you think about this? Is it likely that we break android/ios at some points with this change?
<Jikstra> we have to be careful with panics in the ffi just because array is a null pointer
<Jikstra> the api allowed us to do weird stuff, panicing will break all apps based on -core-rust
<link2xt[m]> yes, but such panics can be easily debugged
<link2xt[m]> if FFI call panics, it panics immediately
<link2xt[m]> and then you know you should not pass invalid value into it
<link2xt[m]> a simple if is enough to fix it in this case, but it may happen to be an actual bug
Jikstra
approved these changes
Aug 13, 2019
|
Now going to move all unsafe code to FFI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.