fix: remove now redundant "used_account_settings" and "entered_account_settings" from Context.get_info()
#7587
Conversation
`Context.get_info()`
|
I'm not sure if we can also remove |
|
i think, already now even if bots are using setConfig/configure, this will end up in a |
Simon-Laux
changed the title
Context.get_info()Context.get_info()
|
python tests still use some of those properties, so this needs another iteration, converting to draft until it is mergable |
|
|
link2xt
left a comment
link2xt
left a comment
There was a problem hiding this comment.
Let's merge as is, but entered_transport_settings are useful IMO, we had recently some user who configured port 443 manually and this results in resolving mail.*, imap.* etc. domains that do not exist.
|
you can not add relays/transports with invalid configuration. So I think it would be sufficient if the entered & used login params would be just logged to the log on configuration failure. |
|
…n failure (#7610) #7587 removed "used_account_settings" and "entered_account_settings" from Context.get_info(). link2xt pointed out that entered_account_settings can still be useful to debug login issues, so tis pr adds logs both on failed configuration attempts. example warning event: ``` Warning src/configure.rs:292: configure failed: entered params [email protected] imap:unset:***:unset:0:Automatic:AUTH_NORMAL smtp:unset:0:unset:0:Automatic:AUTH_NORMAL cert_automatic, used params [email protected] imap:[mailcow.testrun.org:993:tls:[email protected], mailcow.testrun.org:143:starttls:[email protected]] smtp:[mailcow.testrun.org:465:tls:[email protected], mailcow.testrun.org:587:starttls:[email protected]] provider:none cert_automatic ``` --------- Co-authored-by: iequidoo <[email protected]>
follow up to #7583