Skip to content

Conversation

@r10s
Copy link
Contributor

@r10s r10s commented Dec 22, 2025

seems, this event is not only for tests or debugging, but needed also when transport was modified on another device.

came over that via deltachat/deltachat-desktop#5895

once merged, UI issues/PR should be filed to listen to that event and update the list

@r10s r10s requested review from Hocuri and link2xt December 22, 2025 11:47
Copy link
Collaborator

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation in events/payload.rs should also be updated then if it is not more used just for tests.

@iequidoo
Copy link
Collaborator

Documentation in events/payload.rs should also be updated then if it is not more used just for tests.

deltachat-jsonrpc/src/api/types/events.rs also

@r10s r10s merged commit 5c339ef into main Dec 23, 2025
30 checks passed
@r10s r10s deleted the r10s/document-transpots-event branch December 23, 2025 11:04
@link2xt
Copy link
Collaborator

link2xt commented Dec 25, 2025

once merged, UI issues/PR should be filed to listen to that event and update the list

I opened deltachat/deltachat-android#4143 and deltachat/deltachat-ios#2970 and https://codeberg.org/lk108/deltatouch/issues/180

Desktop already has deltachat/deltachat-desktop#5895

link2xt added a commit that referenced this pull request Dec 25, 2025
It is a follow-up to #7643
Event is not emitted when the transports are modified on this device
and we should consistently say that this event is not only for testing.
@link2xt
Copy link
Collaborator

link2xt commented Dec 25, 2025

Documentation in events/payload.rs should also be updated then if it is not more used just for tests.

Follow-up PR addressing my own comment: #7652

link2xt added a commit that referenced this pull request Dec 25, 2025
It is a follow-up to #7643
Event is not emitted when the transports are modified on this device
and we should consistently say that this event is not only for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants