Add code formatting and update deprecations #105
+50
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update deprecated chiseltest usage Update deprecated scalatest usage
jackkoenig
approved these changes
Mar 4, 2022
|
I used Mill to build my project, and I tried running the command mill -i __.reformat, but it didn’t seem to format any files. I’m not sure if the source files are being detected correctly. I also set override def millSourcePath = super.millSourcePath / os.up in my build.mill Could that affect Scalafmt’s behavior? How can I check which files are being recognized by the formatter? Any suggestions would be appreciated! |
|
Hi @Knight112357 thanks for your interest in Chisel! You might want to start a discussion at https://github.com/chipsalliance/chisel-template/discussions rather than commenting on a 3-year-old issue :) |
|
Hi @edwardcwang thanks for your advice. Please see #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add .scalafmt support to project
Format all scala files
Update deprecated usage of chiseltest and scalatest