[CLN] Update server error response on JS Client

[jairad26]

Description of changes

The server error message has been adjusted on server error

Unable to connect to the chromadb server (status: ${response.status}). Please try again later. -> Unable to connect to the chromadb server (status: ${response.status}). Please check server status.

Test plan

How are these changes tested?

• Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

[jairad26]

• [CLN] Update server error response on JS Client #5327 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

This PR modifies the error message shown to JS client users when a server connection failure (status 503/504) occurs. The message changes from 'Unable to connect to the chromadb server (status: ${response.status}). Please try again later.' to 'Unable to connect to the chromadb server (status: ${response.status}). Please check server status.' Additionally, there are widespread formatting adjustments (mainly Prettier updates) across several auto-generated and manually maintained files, but the core logic change is only in the relevant error handling code.

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[BestPractice]

This PR mixes a functional change with a large number of formatting changes. To improve reviewability, it's a good practice to separate formatting-only changes into a separate commit. This allows reviewers to focus on the logic changes more easily.

[jairad26]

this is a prettier that hasnt been run in a while basically. the change is just a 2 liner so i think its fine.

[propel-code-bot]

Thanks for the clarification! I understand that these formatting changes are a result of prettier and that the core functional change is indeed small. For minor formatting adjustments like these, it's often acceptable to include them in the same commit, especially if they're part of a routine reformat.

However, as a general best practice, for larger pull requests where formatting changes might obscure significant logical changes, separating them into a dedicated commit (e.g., "chore: Run formatter") can greatly improve reviewability. This allows reviewers to focus on the functional changes without being distracted by extensive whitespace or line-break differences.

Your functional change to the error message is a good improvement, providing more actionable advice to the user. The PR looks good to proceed.

[jairad26]

1 Job Failed:

PR checks / all-required-pr-checks-passed

Step "Decide whether the needed jobs succeeded or failed" from job "all-required-pr-checks-passed" is failing. The last 20 log lines are:

[...]
}
EOM
)"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
  GITHUB_REPO_NAME: chroma-core/chroma
  PYTHONPATH: /home/runner/_work/_actions/re-actors/alls-green/release/v1/src
# ❌ Some of the required to succeed jobs failed 😢😢😢

📝 Job statuses:
📝 python-tests → ✓ success [required to succeed or be skipped]
📝 python-vulnerability-scan → ✓ success [required to succeed or be skipped]
📝 javascript-client-tests → ✓ success [required to succeed or be skipped]
📝 rust-tests → ⬜ cancelled [required to succeed or be skipped]
📝 go-tests → ✓ success [required to succeed or be skipped]
📝 lint → ✓ success [required to succeed]
📝 check-helm-version-bump → ⬜ skipped [required to succeed or be skipped]
📝 delete-helm-comment → ✓ success [required to succeed or be skipped]
Error: Process completed with exit code 1.

---

Summary: 1 successful workflow, 1 failed workflow

• ❌ PR checks (53 jobs succeeded, 1 job failed)
• ✅ Check PR Title (1 job succeeded)

Last updated: 2025-08-21 11:20:10 UTC